On Wed, Sep 29, 2010 at 07:54:32PM +0200, Arkadiusz Miskiewicz wrote: > On Wednesday 29 of September 2010, Lukas Czerner wrote: > > Pass MKFS_OPTIONS to mkfs.$FSTYP in _scratch_mkfs_sized(). > > Preserve user defined MKFS_OPTIONS in _scratch_mkfs_geom(). > > --- > > common.rc | 6 +++--- > > 1 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/common.rc b/common.rc > [...] > > case $FSTYP in > > xfs) > > - MKFS_OPTIONS="-b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult" > > + MKFS_OPTIONS+="-b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult" > > common.rc uses /bin/sh and += notation is a bashizm. Won't work on strict > posix shells. We've converted all of xfstests to use bash rather than bin/sh because of all the bashisms in the code, so this is fine. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
