On Wed, 2010-09-22 at 19:45 +0200, Arkadiusz MiÅkiewicz wrote: > Add projid32bit handling to userspace. mkfs is able to enable this > feature for new filesystems. xfs_db knows what projid_lo/hi are. I forgot to mention this before. Now that I see man pages I think I should do so. You should use the term "identifiers" rather than the (non-word) "identificators" throughout. A number of the comments I had on the kernel XFS code apply to the user-space counterpart code here, so I won't offer those comments here. I will just ask that you make the two be consistent with each other where there is matching code. I haven't given this code a very thorough review, just a scan for the most part. I'd like to hear your thoughts on my suggestions from your XFS patch. -Alex > Signed-off-by: Arkadiusz MiÅkiewicz <arekm@xxxxxxxx> > --- > > What has changed? > - sb_bad_features2 is also updated > - bstat_get_projid helper added _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs