The segment fault with NULL point using when recovering failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



xlog_recover_process_iunlinks(
    xlog_t        *log)
{
                /*
                 * Reacquire the agibuffer and continue around
                 * the loop. This should never fail as we know
                 * the buffer was good earlier on.
                 */
                error = xfs_read_agi(mp, NULL, agno, &agibp);
                ASSERT(error == 0);
                agi = XFS_BUF_TO_AGI(agibp);
 
}
If no defined DEBUG, ASSERT will not work and agibp could be ZERO if there is a error in xfs_read_agi.
And the comment shouldn't say it never fail because  xfs_read_agi will return error in function and it does when there is forced shutdown.

Thanks,
Mike Gao


_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux