On Tue, 2010-09-14 at 20:56 +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > xfs_buf_get_nodaddr() is really used to allocate a buffer that is > uncached. While it is not directly assigned a disk address, the fact > that they are not cached is a more important distinction. With the > upcoming uncached buffer read primitive, we should be consistent > with this disctinction. > > While there, make page allocation in xfs_buf_get_nodaddr() safe > against memory reclaim re-entrancy into the filesystem by changing > the allocation to GFP_NOFS. This could be spun into its own patch (#19 or more). But I don't think it's that important. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > --- > fs/xfs/linux-2.6/xfs_buf.c | 6 +++--- > fs/xfs/linux-2.6/xfs_buf.h | 2 +- Looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
