On Tue, Jul 27, 2010 at 03:47:31PM +1000, Dave Chinner wrote:
> +
> + /*
> + * can't hold the ILOCK while flushing pages, so flush now we won't get
> + * new pages cached as we hold the XFS_IOLOCK_EXCL.
> + */
> + if (VN_CACHED(VFS_I(tip)) != 0) {
There's really no point in the VN_CACHED check here. Not only does
xfs_flushinval_pages repeat it at the beginning, but it's also
rather superflous as filemap_write_and_wait deals with the condition
of no attached pages efficiently.
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
