On Sun, Jul 18, 2010 at 04:38:51PM -0400, Christoph Hellwig wrote:
> Since Linux 2.6.33 the kernel has support for real O_SYNC, which made
> the osyncisosync option a no-op. Warn the users about this and remove
> the mount flag for it.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks good, but I think these messages:
>
> @@ -366,9 +363,11 @@ xfs_parseargs(
> cmn_err(CE_WARN,
> "XFS: ihashsize no longer used, option is deprecated.");
> } else if (!strcmp(this_char, "osyncisdsync")) {
> - /* no-op, this is now the default */
> cmn_err(CE_WARN,
> - "XFS: osyncisdsync is now the default, option is deprecated.");
> + "XFS: the osyncisdsync option is deprecated as has no effect.");
> + } else if (!strcmp(this_char, "osyncisosync")) {
> + cmn_err(CE_WARN,
> + "XFS: the osyncisosync option is deprecated as has no effect.");
> } else if (!strcmp(this_char, "irixsgid")) {
> cmn_err(CE_WARN,
> "XFS: irixsgid is now a sysctl(2) variable, option is deprecated.");
Look better as:
"XFS: osyncisdsync has no effect, option is deprecated."
"XFS: osyncisosync has no effect, option is deprecated."
so they are consistent with the other deprecated option output.
I've made this change to the patch i have in my tree....
Otherwise,
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
