> - lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP); > + lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP|KM_NOFS); KM_NOFS by itself actually is sufficiant. If you want to keep the KM_SLEEP for documentation purposes at least add some spaces to make it more redable. lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP | KM_NOFS); Once getting outside of nitpicking territory this looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs