On Wed, Jul 14, 2010 at 02:28:36PM -0400, Christoph Hellwig wrote: > Looks good, except that I'd rework the snipplet below > > > status = xfs_buf_iorequest(bp); > > - if (!status && !(flags & XBF_ASYNC)) > > + if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))) > > status = xfs_buf_iowait(bp); > > return status; > > as: > > if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)) > return status; > return xfs_buf_iowait(bp); > > to make it a bit more clear. Make sense. Fixed it up. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
