On Sun, Jul 11, 2010 at 10:43:09PM -0500, Alex Elder wrote: > On Mon, 2010-06-28 at 10:34 -0400, Christoph Hellwig wrote: > > These days we always have buffers thanks to ->page_mkwrite. And we already > > have an assert a few lines above tripping in case that was not true due to > > a bug. > > Should the ASSERT() be made stronger (i.e., BUG_ON())? > Looks to me like we'll crash if it ever happens in a > non-debug kernel, and a BUG() call would more directly > tell us what the problem was... The crash tells it quite directly as well, the ASSERT is there more as a documentation of what we require. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
