Re: [PATCH] Check block magic number so we scan only valid blocks.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 07, 2010 at 11:09:11AM -0400, Peter Watkins wrote:
> Hello,
> 
> Occasionally I've hit a SEGV while querying free space in xfs_db on a mounted
> file system. In scanfunc_bno, block->bb_numrecs has crazy values. And bb_magic 
> is not XFS_ABTB_MAGIC.
> 
> Does a check like this, similiar to other places, make sense?

Yes, it's reasonable.  As long as you'd don't expect directly poking at
a life partition giving correct results..


> Should scanfunc_cnt make a similiar check?

Yes.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux