On Tue, 2010-06-29 at 09:35 -0400, Christoph Hellwig wrote: > On Mon, Jun 28, 2010 at 05:04:52PM -0500, Alex Elder wrote: > > XFS defines a bunch of DMAPI cruft in xfs_mount.h. There is no need > > for it to be there; move it instead into the xfs_dmapi.h file. A > > side-effect of this is that "xfs_dmapi.h" now depends on and needs > > to be #included after "xfs_mount.h" and "xfs_inode.h" (the latter of > > which itself depends on a "xfs_bmap_btree.h"). > > > > On the other hand, "xfs_dmapi.h" is #included by a LOT more files > > than it needs to be, so eliminate those cases. > > > > Finally, "xfs_inode.h" defines a type dm_attrs_t that is never > > referenced anywhere else, so kill it off. > > Asserting copyright on removing single include lines seems rather > interesting.. I simply updated the copyright on every file I touched. We've been advised that "SGI" is the new description of the company in copyright statements, so I was just doing a blanket update. I'll keep those changes, but will drop the ones where I actually added a copyright that wasn't there before. Looks like only one of the 64 files changed fits that description ("linux-2.6/xfs_quotaops.c"). -Alex _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs