Andi Kleen wrote: > On Mon, Jun 14, 2010 at 03:39:58PM +0200, Andi Kleen wrote: >> On Mon, Jun 14, 2010 at 02:48:04PM +0200, Christoph Hellwig wrote: >>> On Mon, Jun 14, 2010 at 10:59:33AM +0200, Andi Kleen wrote: >>>>> How can this work? bp->data is a void pointer. >>>> It compiled with CONFIG_XFS_DEBUG enabled. Do I need to set some other >>>> option to test this? >>> It fails for me in a normal CONFIG_XFS_DEBUG build: >>> >>> fs/xfs/xfs_da_btree.c: In function 'xfs_da_root_join': >>> fs/xfs/xfs_da_btree.c:737: warning: dereferencing 'void *' pointer >>> fs/xfs/xfs_da_btree.c:737: error: request for member 'magic' in >>> something not a structure or union >>> fs/xfs/xfs_da_btree.c:737: warning: dereferencing 'void *' pointer >> >> Hmm, it really compiled here (scratching head) > > Never mind, it seems SUBDIRS doesn't set the DEBUG flag correctly. really? $ make SUBDIRS=fs/xfs CC [M] fs/xfs/linux-2.6/xfs_super.o fs/xfs/linux-2.6/xfs_super.c:73:2: error: #error DEBUG make[1]: *** [fs/xfs/linux-2.6/xfs_super.o] Error 1 $ grep -A3 XFS_DEBUG fs/xfs/linux-2.6/xfs_super.c #ifdef CONFIG_XFS_DEBUG #error DEBUG #endif (above just for testing) Offtopic I guess, but it sure seems to set it for me. -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
