On Tue, Jun 15, 2010 at 03:40:28AM -0400, Christoph Hellwig wrote: > On Tue, Jun 15, 2010 at 09:02:45AM +0200, Andi Kleen wrote: > > I suspect you miss quite a lot of valuable information from > > your user base by not supporting kerneloops.org. On the other > > hand it would likely also save you from spending time on > > flakes. > > > > That said you don't need BUG_ON to support it (WARN etc. work > > too), it's just the easiest way. > > Note that a XFS filesystem shutdown already gives a stack trace. > But picking up every filesystem shutdown on kerneloops.org seems > to be quite a bit too much. It's usually due to IO errors from > the underlying device. Yes, but known race check asserts should be probably there, right? Maybe you need a special kind of ASSERT (or shutdown) for those? -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs