Sorry to pick up an old-ish thread, but I have a similar situation: On Sun, May 23, 2010 at 9:19 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Sun, May 23, 2010 at 09:23:44AM -0500, Roman Kononov wrote: >> On 2010-05-23, 20:18:56 +1000, Dave Chinner <david@xxxxxxxxxxxxx> wrote: >> > Can you find out what the application is triggering this? I noticed this happening with mysql and xtrabackup -- the latter opens up mysql's files while mysql is still running (and modifying its own files) and backs them up in a (hopefully) safe way. mysql had been running on the machine without any such warnings for a while before we ran the backup, so I'm pretty sure that the backup is involved, although its process is never listed. Specifically the warning is: [2584257.839386] ------------[ cut here ]------------ [2584257.839395] WARNING: at fs/xfs/linux-2.6/xfs_lrw.c:651 xfs_write+0x3dc/0x784() [2584257.839398] Hardware name: PowerEdge R710 [2584257.839399] Modules linked in: nfsd cifs iTCO_wdt iTCO_vendor_support [2584257.839406] Pid: 7761, comm: mysqld Not tainted 2.6.33-gentoo-r2 #1 [2584257.839407] Call Trace: [2584257.839411] [<ffffffff8120da46>] ? xfs_write+0x3dc/0x784 [2584257.839415] [<ffffffff81038733>] warn_slowpath_common+0x77/0xa4 [2584257.839417] [<ffffffff8103876f>] warn_slowpath_null+0xf/0x11 [2584257.839419] [<ffffffff8120da46>] xfs_write+0x3dc/0x784 [2584257.839424] [<ffffffff810033ce>] ? apic_timer_interrupt+0xe/0x20 [2584257.839427] [<ffffffff8120a51a>] xfs_file_aio_write+0x5a/0x5c [2584257.839430] [<ffffffff810d7cbe>] do_sync_write+0xc0/0x106 [2584257.839435] [<ffffffff810ff862>] ? __fsnotify_parent+0xc7/0xd3 [2584257.839437] [<ffffffff810d8624>] vfs_write+0xab/0x105 [2584257.839439] [<ffffffff810d86da>] sys_pwrite64+0x5c/0x7d [2584257.839442] [<ffffffff81002a6b>] system_call_fastpath+0x16/0x1b [2584257.839444] ---[ end trace 8b0c2a6e5e86745f ]--- > Yes, it should be safe, but the kernel code can't know whether this > is true or not - there are no specific interlocks with direct IO to > prevent concurrent buffered IO to the same region while a direct IO > is in progress. XFS does best effort attempts to maintain coherency > does not provide any guarantees, hence the warning when known race > conditions are tripped. Would it be safe to remove the warning at fs/xfs/linux-2.6/xfs_lrw.c:651 (which looks like it has moved to xfs_file.c in 2.6.34)? It seems undesirable to get a long stream of these (51 in this particular instance) every time we run a backup... IOW, is the warning purely something along the lines of "Userspace is doing something wonky, but the underlying FS will still be fine no matter what" kind of deal, or could there be an actual problem with the XFS metadata itself? Thanks for any advice, Ilia Mirkin imirkin@xxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
