Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2
- From: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>
- Date: Wed, 14 Aug 2019 13:19:57 +0300
- In-reply-to: <05e5d15b-5ef9-b4dc-a76c-0d423fb2f15d@fb.com>
- Mail-followup-to: Yonghong Song <yhs@xxxxxx>, "magnus.karlsson@xxxxxxxxx" <magnus.karlsson@xxxxxxxxx>, "bjorn.topel@xxxxxxxxx" <bjorn.topel@xxxxxxxxx>, "davem@xxxxxxxxxxxxx" <davem@xxxxxxxxxxxxx>, "hawk@xxxxxxxxxx" <hawk@xxxxxxxxxx>, "john.fastabend@xxxxxxxxx" <john.fastabend@xxxxxxxxx>, "jakub.kicinski@xxxxxxxxxxxxx" <jakub.kicinski@xxxxxxxxxxxxx>, "daniel@xxxxxxxxxxxxx" <daniel@xxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "bpf@xxxxxxxxxxxxxxx" <bpf@xxxxxxxxxxxxxxx>, "xdp-newbies@xxxxxxxxxxxxxxx" <xdp-newbies@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
- References: <20190813102318.5521-1-ivan.khoronzhuk@linaro.org> <20190813102318.5521-2-ivan.khoronzhuk@linaro.org> <05e5d15b-5ef9-b4dc-a76c-0d423fb2f15d@fb.com>
- User-agent: Mutt/1.9.4 (2018-02-28)
On Wed, Aug 14, 2019 at 12:32:41AM +0000, Yonghong Song wrote:
Hi, Yonghong Song
On 8/13/19 3:23 AM, Ivan Khoronzhuk wrote:
That's needed to get __NR_mmap2 when mmap2 syscall is used.
It seems I did not have this issue on x64 machine e.g., Fedora 29.
My glibc version is 2.28. gcc 8.2.1.
On 64 there is no the issue.
What is your particular system glibc version?
So needing kernel asm/unistd.h is because of older glibc on your
system, or something else? Could you clarify?
It doesn't fix build issues, only runtime one on 32bits.
If no such inclusion -> no __NR_mmap2 definition - just mmap() is used ->
no problems on x64.
Is the inclusion -> no NR_mmap2 or is NR_mmap2 -> no problems on x64
--
Regards,
Ivan Khoronzhuk
[Index of Archives]
[Linux Networking Development]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite Campsites]
