From: YueHaibing <yuehaibing@xxxxxxxxxx> Date: Wed, 3 Jul 2019 02:42:13 +0000 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/socionext/netsec.c: In function 'netsec_clean_tx_dring': > drivers/net/ethernet/socionext/netsec.c:637:15: warning: > variable 'pkts' set but not used [-Wunused-but-set-variable] > > It is not used since commit ba2b232108d3 ("net: netsec: add XDP support") > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > drivers/net/ethernet/socionext/netsec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c > index 5544a722543f..015d1ec5436a 100644 > --- a/drivers/net/ethernet/socionext/netsec.c > +++ b/drivers/net/ethernet/socionext/netsec.c > @@ -634,7 +634,7 @@ static void netsec_set_rx_de(struct netsec_priv *priv, > static bool netsec_clean_tx_dring(struct netsec_priv *priv) > { > struct netsec_desc_ring *dring = &priv->desc_ring[NETSEC_RING_TX]; > - unsigned int pkts, bytes; > + unsigned int bytes; > struct netsec_de *entry; > int tail = dring->tail; > int cnt = 0; This breaks the reverse christmas-tree ordering of the local variables in this function. Please move the 'bytes' declaration down by two lines when you make this change. Thanks.
![]() |