Re: [PATCH] thunderbolt: xdomain: Fix to check return value of kmemdup
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] thunderbolt: xdomain: Fix to check return value of kmemdup
- From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
- Date: Wed, 20 Mar 2019 12:51:04 +0200
- In-reply-to: <20190318225508.7886-1-pakki001@umn.edu>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20190318225508.7886-1-pakki001@umn.edu>
- User-agent: Mutt/1.11.3 (2019-02-01)
On Mon, Mar 18, 2019 at 05:55:08PM -0500, Aditya Pakki wrote:
> @@ -1417,8 +1420,7 @@ bool tb_xdomain_handle_request(struct tb *tb, enum tb_cfg_pkg_type type,
> */
> if (uuid_equal(&hdr->uuid, &tb_xdp_uuid)) {
> if (type == TB_CFG_PKG_XDOMAIN_REQ) {
> - tb_xdp_schedule_request(tb, hdr, size);
> - return true;
> + return tb_xdp_schedule_request(tb, hdr, size);
Please remove parens as well that there is only a single statement
following the if-block.
Otherwise looks fine.
[Index of Archives]
[Linux Networking Development]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite Campsites]