Hello, On Mon, Feb 03, 2025 at 12:13:16PM +0100, Vlastimil Babka wrote: > The subsystem status is currently reported with --role(stats) by > adjusting the maintainer role for any status different from Maintained. > This has two downsides: > > - if a subsystem has only reviewers or mailing lists and no maintainers, > the status is not reported (i.e. typically, Orphan subsystems have no > maintainers) > > - the Supported status means that someone is paid for maintaining, but > it is reported as "supporter" for all the maintainers, which can be > incorrect. People have been also confused about what "supporter" > means. > > This patch introduces a new --substatus option and functionality aimed > to report the subsystem status separately, without adjusting the > reported maintainer role. After the e-mails are output, the status of > subsystems will follow, for example: > > ... > linux-kernel@xxxxxxxxxxxxxxx (open list:LIBRARY CODE) > LIBRARY CODE status: Supported > > In order to allow replacing the role rewriting seamlessly, the new > option works as follows: > > - it is automatically enabled when --email and --role are enabled > (the defaults include --email and --rolestats which implies --role) > > - usages with --norolestats e.g. for git's --cc-cmd will thus need no > adjustments > > - the most common Maintained status is not reported at all, to reduce > unnecessary noise > > - THE REST catch-all section (contains lkml) status is not reported > > - the existing --subsystem and --status options are unaffected so their > users will need no adjustments > > Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx> This patch is in next as c1565b6f7b53ea1ea3e757538832e12d7d13d949. It breaks one of my scripts that I use to semi-automatically determine recipents for patch series. It works as follows: $ batch-add-recipents audin-patch-v1/0001-ASoC-meson-HACK-let-AIU-export-its-clocks-through-cl.patch #!/bin/sh addrecipent \ -t "Rob Herring <robh@xxxxxxxxxx>" $(: maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) \ -t "Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>" $(: maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) \ -t "Conor Dooley <conor+dt@xxxxxxxxxx>" $(: maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) \ -t "Neil Armstrong <neil.armstrong@xxxxxxxxxx>" $(: maintainer:ARM/Amlogic Meson SoC support) \ -t "Kevin Hilman <khilman@xxxxxxxxxxxx>" $(: maintainer:ARM/Amlogic Meson SoC support) \ -c "Jerome Brunet <jbrunet@xxxxxxxxxxxx>" $(: reviewer:ARM/Amlogic Meson SoC support) \ -c "Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>" $(: reviewer:ARM/Amlogic Meson SoC support) \ -t "Liam Girdwood <lgirdwood@xxxxxxxxx>" $(: supporter:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...) \ -t "Mark Brown <broonie@xxxxxxxxxx>" $(: supporter:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...) \ -t "Jaroslav Kysela <perex@xxxxxxxx>" $(: maintainer:SOUND) \ -t "Takashi Iwai <tiwai@xxxxxxxx>" $(: maintainer:SOUND) \ -c "devicetree@xxxxxxxxxxxxxxx" $(: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) \ -c "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" $(: moderated list:ARM/Amlogic Meson SoC support) \ -c "linux-amlogic@xxxxxxxxxxxxxxxxxxx" $(: open list:ARM/Amlogic Meson SoC support) \ -c "linux-kernel@xxxxxxxxxxxxxxx" $(: open list) \ -c "linux-sound@xxxxxxxxxxxxxxx" $(: open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...) \ audin-patch-v1/0001-ASoC-meson-HACK-let-AIU-export-its-clocks-through-cl.patch the output is usually redirected to a file that I edit before running it. The additional line in the output of scripts/get_maintainer.pl audin-patch-v1/0001-ASoC-meson-HACK-let-AIU-export-its-clocks-through-cl.patch with your change breaks that script. #regzbot introduced: c1565b6f7b53ea1ea3e757538832e12d7d13d949 #regzbot title: get_maintainer's subsystem status output breaks custom script I can cope with it, but still wanted to let you know that people use get_maintainers for `git --cc-cmd`-like usages without --norolestats. Given that I use scripts/get_maintainer.pl from the tree I currently work at and sometimes that is based on next, sometimes on linus/master or -rc1 and sometimes even older trees (e.g. stable), the introduced `--no-substatus` option doesn't help me because when run from a tree without your change I get: $ scripts/get_maintainer.pl --no-substatus audin-patch-v1/0001-ASoC-meson-HACK-let-AIU-export-its-clocks-through-cl.patch Unknown option: no-substatus scripts/get_maintainer.pl: invalid argument - use --help if necessary so I cannot use that option easily until all the trees I care about get your change. :-\ Best regards Uwe
Attachment:
signature.asc
Description: PGP signature