On Mon, 2024-05-06 at 19:16 +1200, Barry Song wrote:
> > > From: Xining Xu <mac.xxn@xxxxxxxxxxx>
> > >
> > > If function-like macros do not utilize a parameter, it might result in a
> > > build warning. In our coding style guidelines, we advocate for utilizing
> > > static inline functions to replace such macros. This patch verifies
> > > compliance with the new rule.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > []
> > > @@ -6040,6 +6040,12 @@ sub process {
> > > CHK("MACRO_ARG_PRECEDENCE",
> > > "Macro argument '$arg' may be better as '($arg)' to avoid precedence issues\n" . "$herectx");
> > > }
> > > +
> > > +# check if this is an unused argument
> > > + if ($define_stmt !~ /\b$arg\b/) {
> > > + WARN("MACRO_ARG_UNUSED",
> > > + "Argument '$arg' is not used in function-like macro\n" . "$herectx");
> >
> > trivia: This should be aligned to the open parenthesis.
> >
>
> Hi Joe,
> I assume you mean the below?
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9895d7e38a9f..2b812210b412 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -6044,7 +6044,7 @@ sub process {
> # check if this is an unused argument
> if ($define_stmt !~ /\b$arg\b/) {
> WARN("MACRO_ARG_UNUSED",
> - "Argument '$arg' is not used in function-like macro\n" . "$herectx");
> + "Argument '$arg' is not used in function-like macro\n" . "$herectx");
> }
> }
> > Otherwise:
> > Acked-by: Joe Perches <joe@xxxxxxxxxxx>
Yes, but please send a v7 instead of a separate patch
to akpm or perhaps Andrew could combine them or fix it
when applying v6
