[CCing Sasha]
On 18.04.24 15:20, Greg KH wrote:
> On Thu, Apr 18, 2024 at 09:04:53AM +0200, Thorsten Leemhuis wrote:
>> On 17.04.24 15:38, Greg KH wrote:
>>> On Wed, Apr 17, 2024 at 03:21:12PM +0200, Thorsten Leemhuis wrote:
>>>> On 17.04.24 14:52, Konstantin Ryabitsev wrote:
>>>>> On Wed, Apr 17, 2024 at 09:48:18AM +0200, Thorsten Leemhuis wrote:
>>>>>> Could you please create the email alias
>>>>>>
>>>>>>> How about:
>>>>>>> cc: <do-not-apply-to-stable@xxxxxxxxxx> # Reason goes here, and must be present
>>>>>>>
>>>>>>> and we can make that address be routed to /dev/null just like
>>>>>>> <stable@xxxxxxxxxx> is?
>>>>
>>>> FWIW, we could go back to what I initially proposed: use the existing
>>>> stable tag with a pre-defined comment to mark patches that AUTOSEL et.
>>>> al. should not pick up:
>>>> https://lore.kernel.org/all/c0a08b160b286e8c98549eedb37404c6e784cf8a.1712812895.git.linux@xxxxxxxxxxxxx/
>>>
>>> If you can pick a better string, possibly, yes.
>>
>> What did you think of Konstantin's
>>
>> Cc: stable+noautosel@xxxxxxxxxx # Reason
@Greg, BTW: should this be stable+noautosel@xxxxxxxxxx or have a 'vger.'
in it, e.g. stable+noautosel@xxxxxxxxxxxxxxx? I assume without 'vger.'
is fine, just wanted to be sure, as
Documentation/process/stable-kernel-rules.rst in all other cases
specifies stable@xxxxxxxxxxxxxxx, so people are likely to get confused.
:-/ #sigh
>> That looked like a good solution -- and I wondered why I did not come up
>> with that idea myself. Sure, "autosel" would also imply/mean "the
>> scripts/tools that look out for Fixes: tags", but does that matter?
>
> We can live with this, sure.
In that case I guess I now also have to fix the scripts to honor that tag.
@Greg: something like the attached for scripts/fixes_search perhaps? Was
that the right one and are there any other scripts that might need
something similar?
@Sasha: are the scripts around autosel online somewhere? They need a
similar change.
Ciao, Thorsten
From 1e973a069b07f8c045401a7d3d20ea760a27422f Mon Sep 17 00:00:00 2001
From: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>
Date: Mon, 22 Apr 2024 17:31:01 +0200
Subject: [PATCH] scripts/fixes_search: honor noautosel tag
Ignore commits that contain a soon to be documented tag that is
meant to exclude commits from processing by scripts like
scripts/fixes_search.
Link: https://lore.kernel.org/all/2024041830-karaoke-aspirate-df00@gregkh/ [1]
Signed-off-by: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>
---
scripts/fixes_search | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/fixes_search b/scripts/fixes_search
index aaa12ec..950509f 100755
--- a/scripts/fixes_search
+++ b/scripts/fixes_search
@@ -131,6 +131,13 @@ for commit in $(git rev-list --reverse --no-merges "${git_range}"); do
# logn "commit = ${txtgrn}${commit}${txtrst} "
logn "${txtgrn}${commit}${txtrst} "
+ # Check if we are supposed to ignore the commit
+ no_autosel=$(git log -1 --format='%B' "HEAD" | grep -i '^[[:space:]]*[Cc][Cc]:[[:space:]]*<stable+noautosel@')
+ if [ "${no_autosel}" ] ; then
+ log "${txtblu}contains noautosel tag${txtrst}"
+ continue
+ fi
+
# Try to find "Fixes" tag in commit
fixes_lines=$(git log -1 --format='%B' "${commit}" | grep -i '^[[:space:]]*Fixes:')
if [ "${fixes_lines}" == "" ] ; then
--
2.44.0
