On Mon, Apr 15, 2024 at 01:07:41AM -0700, Christoph Hellwig wrote: > No, this advice is wronger than wrong. If you set panic_on_warn you > get to keep the pieces. > But don't add new WARN() calls please, just properly clean up and handle the error. And any WARN() that userspace can trigger ends up triggering syzbot reports which also is a major pain, even if you don't have panic_on_warn enabled. And I think the "do not use panic_on_warn" recommendation has been ignored, given the huge use of it by vendors who have enabled it (i.e. all Samsung phones and cloud servers). thanks, greg k-h
