On Wed, 2024-04-03 at 10:21 +1300, Barry Song wrote: > On Wed, Apr 3, 2024 at 5:13 AM Jonathan Corbet <corbet@xxxxxxx> wrote: > > > > So I'm not sure what your desired path for getting this upstream is. I > > can take it, but I'm generally quite leery of taking coding-style > > changes without some serious acks on them - nobody elected me as the > > arbiter of proper coding style. I believe it is generally appropriate for macros that take arguments to use static inlines where feasible, so: Acked-by: Joe Perches <joe@xxxxxxxxxxx> And yes, mm is the usual path for upstreaming at least this sort of checkpatch change.