On Fri, Mar 29, 2024 at 5:01 AM Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:
>
> On 3/27/2024 7:21 PM, Barry Song wrote:
> > From: Xining Xu <mac.xxn@xxxxxxxxxxx>
> >
> > If function-like macros do not utilize a parameter, it might result in a
> > build warning. In our coding style guidelines, we advocate for utilizing
> > static inline functions to replace such macros. This patch verifies
> > compliance with the new rule.
> >
> > For a macro such as the one below,
> >
> > #define test(a) do { } while (0)
> >
> > The test result is as follows.
> >
> > ERROR: Parameter 'a' is not used in function-like macro, please use static
> > inline instead
> > #21: FILE: mm/init-mm.c:20:
> > +#define test(a) do { } while (0)
> >
> > total: 1 errors, 0 warnings, 8 lines checked
> >
> > Signed-off-by: Xining Xu <mac.xxn@xxxxxxxxxxx>
>
> if you are re-posting somebody else's work you need to add your own Signed-off-by
Ok. Jeff, I will do it in the new version and obviously Joe still has
some remaining
comments to be addressed by Xining.
>
> > Tested-by: Barry Song <v-songbaohua@xxxxxxxx>
> > Cc: Chris Zankel <chris@xxxxxxxxxx>
> > Cc: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Cc: Mark Brown <broonie@xxxxxxxxxx>
> > Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx>
> > Cc: Dwaipayan Ray <dwaipayanray1@xxxxxxxxx>
> > Cc: Joe Perches <joe@xxxxxxxxxxx>
> > Cc: Jonathan Corbet <corbet@xxxxxxx>
> > Cc: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> > Cc: Max Filippov <jcmvbkbc@xxxxxxxxx>
>
