On Thursday, November 16, 2023 09:14 -03, Nikolai Kondrashov <Nikolai.Kondrashov@xxxxxxxxxx> wrote: > On 11/15/23 22:38, Konstantin Ryabitsev wrote: > > On Wed, Nov 15, 2023 at 07:43:49PM +0200, Nikolai Kondrashov wrote: > >> Introduce a new tag, 'Tested-with:', documented in the > >> Documentation/process/submitting-patches.rst file. The tag is expected > >> to reference the documented test suites, similarly to the 'V:' field, > >> and to certify that the submitter executed the test suite on the change, > >> and that it passed. > > > > I'm not sure it should be a tag that stays all the way through git commit. > > How about making it a cover letter/first patch footer? > > > > tested-with: <suite> > > Yes, that would be better indeed. However, checkpatch.pl doesn't process cover > letters, and so we would have no automated way to advertise and nudge people > towards testing. At this year's LPC, there was quite some discussion around improving testing information, so this patch of yours lands has a great timing. :) All your are proposing here is pretty interesting both for developers and CI systems, but it seems that a "Tested-with:" tag and checkpatch.pl validation will take quite some time to consolidate. Would it make sense to split just the part that adds the V: field to MAINTAINERS and submit that as separate patchset together with its documentation? That way we can enable subsystem to start annotating their test suites already. I also wonder how to make for subsystems that will have different test suites (eg something in kselftests and an external test suite). Would an alternative be pointing to a Documentation page with detailed info? - Gus -- Gustavo Padovan Kernel Lead Collabora Ltd.
