Re: [PATCH v3 1/2] docs: add a document about regression handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 26.01.22 15:10, Thorsten Leemhuis wrote:
> On 26.01.22 00:59, Jonathan Corbet wrote:
>> Thorsten Leemhuis <linux@xxxxxxxxxxxxx> writes:

>>> +   Note: Only the content of this RST file as found in the Linux kernel sources
>>> +   is available under CC-BY-4.0, as versions of this text that were processed
>>> +   (for example by the kernel's build system) might contain content taken from
>>> +   files which use a more restrictive license.
>> I wonder if we could put this boilerplate at the bottom, with a single
>> "see the bottom for redistribution information" line here?  Most readers
>> won't care about this stuff and shouldn't have to slog through it to get
>> to what they want to read.
> Totally fine with me. When I touch reporting-issues.rst the next time
> I'll move it downwards as well.

V4 will do that, as I added a patch to point from reporting-issues.rst
to one of the two new documents.

>>> +The important bits for people affected by regressions
>>> +=====================================================
>>> +
>>> +It's a regression if something running fine with one Linux kernel works worse or
>>> +not at all with a newer version. Note, the newer kernel has to be compiled using
>>> +a similar configuration -- for this and other fine print, check out below
>>> +section "What is a 'regression' and what is the 'no regressions rule'?".
>> Can we be consistent with either single or double quotes?  I'd suggest
>> "double quotes" but won't make a fuss about that.
> Changed to "double quotes" everywhere in the text. But just to make sure
> I get things right: in this particular case this will result in
> ...section "What is a "regression" and what is the "no regressions rule"?".
> This looks a bit strange to me. Something in me really would like to
> quote the section's header in single quotes, but I guess grammar rules
> do not allow that, so whatever. :-D

I changed something and now simply don't mentioned the section names to
avoid this problem. After the split that's not strictly needed afaics.

>>> +Report your regression as outlined in
>>> +`Documentation/admin-guide/reporting-issues.rst`, it already covers all aspects
>> No need to quote the file name.
> Okay, I thought I had seen some commit or instructions that it's better
> to use them in this case, but my brain must have imagined it.

I noticed I quoted internal references in reporting-issues.rst quite
often. IMHO it improves readability sometimes (it depends a lot on the
title of the target document), as can be seen in this example:

If your kernel is tainted, study
'Documentation/admin-guide/tainted-kernels.rst' to find out why.
To find the change there is a process called 'bisection' which the document
'Documentation/admin-guide/bug-bisect.rst' describes in detail.

after processing to HTML looks like this:

If your kernel is tainted, study 'Tainted kernels' to find out why.
To find the change there is a process called ‘bisection’ which the
document ‘Bisecting a bug’ describes in detail.

Sure, "Tainted kernels" and "Bisecting a bug" are links and hence
displayed differently by the browser, but I think the quotes help. But YMMV.

I sooner or later hope to improve and fix a few things in
reporting-issues.rst anyway. Let me know if I should take the
opportunity to remove the single quotes then.

>>> +Who needs to find the commit causing a regression?
>>> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> +
>>> +It's the reporter's duty to find the culprit, but developers of the affected
>>> +subsystem should offer advice and reasonably help where they can.
>> Is it really our policy that *reporters* need to find the offending
>> commit?  That's certainly not my view of things, anyway?

BTW, I noticed reporting-issues.rst covers it like this:

Normally it's up to the reporter to track down the culprit, as
maintainers often won't have the time or setup at hand to reproduce it

> Well, do we have something on that written down somewhere or a few
> quotes from Linus that might help to clarify things?
> Anyway: I was not totally happy with it either, as I found the first
> part of the sentence to strong, and the second to soft. But I had
> trouble finding something better, maybe a native speaker could help out
> here. Maybe something along these lines?

I plan to go with this now:
Who needs to find the root cause of a regression?

Developers of the affected code area should try to locate the culprit on
their own. But for them that's often impossible to do with reasonable
effort, as quite a lot of issues only occur in a particular environment
outside the developer's reach -- for example, a specific hardware
platform, firmware, Linux distro, system's configuration, or
application. That's why in the end it's often up to the reporter to
locate the culprit commit; sometimes users might even need to run
additional tests afterwards to pinpoint the exact root cause. Developers
should offer advice and reasonably help where they can, to make this
process relatively easy and achievable for typical users.

Ciao, Thorsten

[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux