On Thu, Jun 17, 2021 at 11:11:55AM -0400, Konstantin Ryabitsev wrote: > On Wed, Jun 16, 2021 at 10:10:11PM +0200, Willy Tarreau wrote: > > In haproxy we have a bot that forwards PRs to the mailing list. It > > CCs the author and sends a gentle message saying that reviews are > > made in public using plain-text e-mails, and that for this reason > > the PR is automatically closed. And I think it's easier for both > > sides, because users who are used to PRs would probably count a bit > > too much on the "github mode", where they're certain that someone > > will eventually notice that the PR count went from 1137 to 1138 and > > will have a look, while it's certain that there will be quite some > > losses, and by warning the submitter upfront there is less surprise. > > Good to know. I was only aware of GitGitGadget, so knowing that HAProxy does > it as well is useful. Unfortunately, I can't really use much of GitGitGadget > code as it's too closely integrated into Azure and is written in typescript, > which I don't know at all. Note, I was speaking about a return on experience, not particularly about code. I don't know what language the bot is written in, it's entirely managed by one of our great contributors, but if you're interested in exchanging with him I can put you in contact with him off-list. Anyway if you're interested in seeking some feedback on such practices from other projects, just look for old ones which adopted github long after having solved their versionning issues. Very often the github workflow doesn't suit them at all. Nginx automatically closes PRs for example. For Apache it's not very clear. FreeBSD uses github as a mirror and has very few PRs. Gcc also uses it as a mirror and has very few PRs. Probably these ones use some form of automated bots to close them, or do that in batches once a year. Willy
