On 07/04/2012 03:05 AM, Xose Vazquez Perez wrote: > On 07/04/2012 02:49 AM, Luis R. Rodriguez wrote: >> On Tue, Jul 3, 2012 at 5:41 PM, Xose Vazquez Perez >> <xose.vazquez at gmail.com> wrote: > >>> country ES: DFS-ETSI >>> - (2402 - 2482 @ 40), (N/A, 20) >>> - (5170 - 5250 @ 40), (N/A, 20) >>> - (5250 - 5330 @ 40), (N/A, 20), DFS >>> - (5490 - 5710 @ 40), (N/A, 27), DFS >>> + (2400 - 2483.5 @ 40), (N/A, 100 mW) >>> + (5150 - 5250 @ 40), (N/A, 100 mW), NO-OUTDOOR >>> + (5250 - 5350 @ 40), (N/A, 100 mW), NO-OUTDOOR, DFS >>> + (5470 - 5725 @ 40), (N/A, 500 mW), DFS > >> You are changing from dBm to mW directly... please do the unit change >> in one patch and *then* the actual change. This would make it easier >> to review.... > > I did copy & paste from DE to ES. These are basic CEPT rules. > > 10 log(100) = 20 > 10 log(500) ~ 27 > > Anyway tomorrow, I will send a new patch. Just a general remark not specific to this patch. The commit message often contains a source reference. I think it would be useful to have this reference in the database a well so people validating it do not need to do the digging using 'git blame'. Does that make sense? Gr. AvS
