>From the patch in question (http://archives.free.net.ph/message/20090402.084334.20d9823c.pt-BR.html): > The "instr" parameter to shader_glsl_gen_modifier() is actually a source > parameter, so comparing against WINED3DSIO_TEXKILL is just silly. What was removed was a single if...return check, which according to the information above makes sense. If it didn't make sense, the other Wine/CodeWeavers DirectX developers would have commented on it. There are various checks to make sure that a patch is correct: reviews of patches sent to the mailing list; Alexandre (the ultimate reviewer and applier of patches) and conformance tests. This system is not perfect, and regressions do happen (the Windows API is very big and complex).
