On Thu, Apr 9, 2009 at 5:32 PM, Austin English <austinenglish@xxxxxxxxx> wrote: > On Thu, Apr 9, 2009 at 4:28 AM, Warren Dumortier <nwarrenfl@xxxxxxxxx> wrote: >> Hello everybody... >> >> My patch to add advanced d3d settings in winecfg is almost ready. >> In fact, i only have to figure out how to detect video memory size to >> display it when no key is set to force it or to reset. Stefan D told >> me to use DirectDraw, but i wouldn't find. >> >> So that is the last thing (except some better naming...) to do for this patch. >> >> Everything works well and i would like some feedback. >> >> Thanks, kind regards. >> >> >> >> > > Gives some compiler warnings here: > -limits -Wpointer-arith -g -O2 -o x11drvdlg.o x11drvdlg.c > x11drvdlg.c: In function ‘d3d_advanced_settings_save’: > x11drvdlg.c:451: warning: ISO C90 forbids mixed declarations and code > x11drvdlg.c: In function ‘d3d_advanced_settings_reset’: > x11drvdlg.c:463: warning: passing argument 1 of ‘SetDlgItemTextA’ > makes pointer from integer without a cast > x11drvdlg.c:465: warning: passing argument 1 of ‘SendMessageA’ makes > pointer from integer without a cast > x11drvdlg.c:465: warning: ISO C90 forbids mixed declarations and code > x11drvdlg.c:466: warning: passing argument 1 of ‘SendDlgItemMessageA’ > makes pointer from integer without a cast > x11drvdlg.c:468: warning: passing argument 1 of ‘SendMessageA’ makes > pointer from integer without a cast > x11drvdlg.c:469: warning: passing argument 1 of ‘SendDlgItemMessageA’ > makes pointer from integer without a cast > x11drvdlg.c:471: warning: passing argument 1 of ‘SendMessageA’ makes > pointer from integer without a cast > x11drvdlg.c:472: warning: passing argument 1 of ‘SendDlgItemMessageA’ > makes pointer from integer without a cast > > > Other than that, and the comments Juan and others pointed out, looks good. > > -- > -Austin > Compiling under 64-bit is bit more verbose: /usr/lib/gcc-snapshot/bin/gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o x11drvdlg.o x11drvdlg.c x11drvdlg.c: In function 'd3d_advanced_settings_save': x11drvdlg.c:451: warning: ISO C90 forbids mixed declarations and code x11drvdlg.c: In function 'd3d_advanced_settings_reset': x11drvdlg.c:463: warning: passing argument 1 of 'SetDlgItemTextA' makes pointer from integer without a cast ../../include/winuser.h:4943: note: expected 'HWND' but argument is of type 'int' x11drvdlg.c:465: warning: passing argument 1 of 'SendMessageA' makes pointer from integer without a cast ../../include/winuser.h:4908: note: expected 'HWND' but argument is of type 'int' x11drvdlg.c:465: warning: ISO C90 forbids mixed declarations and code x11drvdlg.c:466: warning: passing argument 1 of 'SendDlgItemMessageA' makes pointer from integer without a cast ../../include/winuser.h:4904: note: expected 'HWND' but argument is of type 'int' x11drvdlg.c:468: warning: passing argument 1 of 'SendMessageA' makes pointer from integer without a cast ../../include/winuser.h:4908: note: expected 'HWND' but argument is of type 'int' x11drvdlg.c:469: warning: passing argument 1 of 'SendDlgItemMessageA' makes pointer from integer without a cast ../../include/winuser.h:4904: note: expected 'HWND' but argument is of type 'int' x11drvdlg.c:471: warning: passing argument 1 of 'SendMessageA' makes pointer from integer without a cast ../../include/winuser.h:4908: note: expected 'HWND' but argument is of type 'int' x11drvdlg.c:472: warning: passing argument 1 of 'SendDlgItemMessageA' makes pointer from integer without a cast ../../include/winuser.h:4904: note: expected 'HWND' but argument is of type 'int' LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -fowinecfg.res winecfg.rc ../../tools/winegcc/winegcc -m64 -B../../tools/winebuild -mwindows appdefaults.o audio.o drive.o drivedetect.o driveui.o libraries.o main.o theme.o winecfg.o x11drvdlg.o winecfg.res -o winecfg.exe.so -luuid -lcomdlg32 -lcomctl32 -lshell32 -lole32 -lwinmm -lshlwapi -luxtheme -luser32 -lgdi32 -ladvapi32 -lkernel32 ../../libs/port/libwine_port.a -- -Austin
