Ran into this while browsing the code, it seems to
be a NULL pointer reference waiting to happen.
Am I missing something?
ChangeLog
Bail when we're out of memory.
Index: dlls/rpcrt4/rpc_binding.c
===================================================================
RCS file: /var/cvs/wine/dlls/rpcrt4/rpc_binding.c,v
retrieving revision 1.15
diff -u -r1.15 rpc_binding.c
--- dlls/rpcrt4/rpc_binding.c 7 Oct 2003 22:54:17 -0000 1.15
+++ dlls/rpcrt4/rpc_binding.c 20 Nov 2003 06:33:52 -0000
@@ -516,7 +516,11 @@
{
DWORD len = strlen(dst), slen = strlen(src);
LPSTR ndst = HeapReAlloc(GetProcessHeap(), 0, dst, (len+slen+2)*sizeof(CHAR));
- if (!ndst) HeapFree(GetProcessHeap(), 0, dst);
+ if (!ndst)
+ {
+ HeapFree(GetProcessHeap(), 0, dst);
+ return NULL;
+ }
ndst[len] = ',';
memcpy(ndst+len+1, src, slen*sizeof(CHAR));
ndst[len+slen+1] = 0;
@@ -527,7 +531,11 @@
{
DWORD len = strlenW(dst), slen = strlenW(src);
LPWSTR ndst = HeapReAlloc(GetProcessHeap(), 0, dst, (len+slen+2)*sizeof(WCHAR));
- if (!ndst) HeapFree(GetProcessHeap(), 0, dst);
+ if (!ndst)
+ {
+ HeapFree(GetProcessHeap(), 0, dst);
+ return NULL;
+ }
ndst[len] = ',';
memcpy(ndst+len+1, src, slen*sizeof(WCHAR));
ndst[len+slen+1] = 0;
--
Dimi.
