SMATCH: mem leak due to misplaced "}"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

found by the unfree-wine.pl smatch script

License: LGPL, X11
Changelog:
	Michael Stefaniuc <mstefani@redhat.com>
	- due to a misplaced "}" memory wasn't freed on the error path

bye
	michael
-- 
Michael Stefaniuc               Tel.: +49-711-96437-199
System Administration           Fax.: +49-711-96437-111
Red Hat GmbH                    Email: mstefani@redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart
Index: dlls/setupapi/queue.c
===================================================================
RCS file: /home/wine/wine/dlls/setupapi/queue.c,v
retrieving revision 1.8
diff -u -r1.8 queue.c
--- dlls/setupapi/queue.c	11 Sep 2003 02:58:46 -0000	1.8
+++ dlls/setupapi/queue.c	26 Sep 2003 23:24:21 -0000
@@ -1036,9 +1036,9 @@
                         docopy = FALSE;
                     }
                 }
-                HeapFree(GetProcessHeap(),0,VersionSource);
-                HeapFree(GetProcessHeap(),0,VersionTarget);
             }
+            HeapFree(GetProcessHeap(),0,VersionSource);
+            HeapFree(GetProcessHeap(),0,VersionTarget);
         }
     }
     if (style & (SP_COPY_NOOVERWRITE | SP_COPY_FORCE_NOOVERWRITE))

Attachment: pgp00188.pgp
Description: PGP signature


[Index of Archives]     [Gimp for Windows]     [Red Hat]     [Samba]     [Yosemite Camping]     [Graphics Cards]     [Wine Home]

  Powered by Linux