Hello, this was found by the wine_lock.pl smatch script. If the call to XAllocSizeHints() dosn't need to be protected by the wine_tsx11_lock then the attached patch can be simplified by just moving the wine_tsx11_lock() call after XAllocSizeHints(). License: LGPL, X11 Changelog: Michael Stefaniuc <mstefani@redhat.com> - missing wine_tsx11_unlock() on error path bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani@redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart
Index: dlls/x11drv/desktop.c
===================================================================
RCS file: /home/wine/wine/dlls/x11drv/desktop.c,v
retrieving revision 1.13
diff -u -r1.13 desktop.c
--- dlls/x11drv/desktop.c 16 Sep 2003 20:24:29 -0000 1.13
+++ dlls/x11drv/desktop.c 25 Sep 2003 23:26:57 -0000
@@ -176,6 +176,7 @@
if (!size_hints)
{
ERR("Not enough memory for window manager hints.\n" );
+ wine_tsx11_unlock();
return 0;
}
size_hints->min_width = size_hints->max_width = width;
Attachment:
pgp00186.pgp
Description: PGP signature
