Re: dlls/avifil32: many implemented functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Dmitry Timoshkov" <dmitry@baikal.ru> writes:

> "Michael GЭnnewig" <MichaelGuennewig@gmx.de> wrote:
...
>> + static WCHAR streamTypeFmt[] = {'%','4','.','4','h','s'};
> ...
>> + wsprintfW(szType, streamTypeFmt, (char*)&streamHdr.fccType);
>
> 1. streamTypeFmt is not NULL terminated.
> 2. If you don't mind, please add a 'const' modifier.

Oops. Thanks. Here is the little patch for fixing these issues.

--- dlls/avifil32/avifile.c.orig	Tue Oct 15 18:13:11 2002
+++ dlls/avifil32/avifile.c	Tue Oct 15 18:13:22 2002
@@ -1620,7 +1620,7 @@
 	  break;
 	case ckidSTREAMHEADER:
 	  {
-	    static WCHAR streamTypeFmt[] = {'%','4','.','4','h','s'};
+	    static const WCHAR streamTypeFmt[] = {'%','4','.','4','h','s',0};
 
 	    AVIStreamHeader streamHdr;
 	    WCHAR           szType[25];


  Michael Günnewig

[Index of Archives]     [Gimp for Windows]     [Red Hat]     [Samba]     [Yosemite Camping]     [Graphics Cards]     [Wine Home]

  Powered by Linux