Just cleaning up my wine tree and found I never did anything with this
patch - I put a question on wine-dev a while ago without any replies so
decided to just submit it anyway.
Bug#446 reported an issue of buffer overflow (which is caused by the missing
/n at a guess) and also an error msg 'illegal combination with
FILE_ATTRIBUTE_NORMAL'.
>From the msdn, it would appear (and testing on w2k at least confirms) that:
rc = SetFileAttributes("fff", FILE_ATTRIBUTE_NORMAL |
FILE_ATTRIBUTE_READONLY );
_is_ valid and sets readonly. In the msdn "However, all other values
override FILE_ATTRIBUTE_NORMAL."
The wine code (files\file.c) prints a fixme if anything is set alongside
attribute_normal:
if (attributes & FILE_ATTRIBUTE_NORMAL) {
attributes &= ~FILE_ATTRIBUTE_NORMAL;
if (attributes)
FIXME("(%s):%lx illegal combination with FILE_ATTRIBUTE_NORMAL.\n",
lpFileName,attributes);
}
The following patch removes this check altogether, alternatively you could
change the FIXME to a TRACE or WARN, but I dont see the point in issuing
error messages to the user for possibly valid situations
Changelog:
- Silence fixme in unnecessary situation, add missing \n to another fixme
Jason
Attachment:
bug446.patch
Description: Binary data
