On 11/4/22 12:11 AM, Lin Ma wrote: > Libvirt domcaps can advertise the redirect devices and spicevmc channel > devices since v8.9.0. > Virt-install adds usb redirdevs and spicevmc channels by default on x86. > This patchset adds checks to avoid using redirect devices/spicevmc channel > devices when not supported by the target qemu. > > Lin Ma (2): > guest: Query availability of usb redirdevs in domcaps > guest: Query availability of spicevmc channels in domcaps > > virtinst/domcapabilities.py | 14 ++++++++++++++ > virtinst/guest.py | 4 ++++ > 2 files changed, 18 insertions(+) > These patches break the test suite very obviously. Can you start submitting PRs via github? CI would have made this clear. They will also regress runtime: now every VM created against older libvirt will think redirdev and spicevmc isn't supported, and not add those devices. Check around in domcapabilities.py for examples of how we have handled this when new libvirt output pops up. You can use a version check, or check for presense of empty redirdev attribute to know that we can trust the empty caps output. - Cole
