On Thu, Apr 21, 2022 at 12:54:42PM +0200, Henrik Riomar wrote: > On Wed, Apr 20, 2022 at 3:42 PM Richard W.M. Jones <rjones@xxxxxxxxxx> wrote: > > > > On Wed, Apr 20, 2022 at 09:33:03AM -0400, Cole Robinson wrote: > > > On 4/19/22 1:25 PM, Henrik Riomar wrote: > > > > Hi, > > > > > > > > Looks like the v1.22 release was never uploaded: > > > > https://people.redhat.com/~rjones/virt-what/files/ > > > > > > > > Can you look into this? > > > > > > > > > > ccing rjones incase he missed this is about virt-what > > > > Sorry about this everyone. It is true that I have not yet uploaded > > the new tarball, and that's because of some internal network issue at > > Red Hat which is taking time to resolve. > > > > Thanks, sems the issue is now resolved at RH as well as the release > tarball is now in place. > > I now note that commit b7cc3d93a613ef6d0ac5ccd6e32cc3d66e057243, that > is part of v1.22 introduced two bashisms: > > possible bashism in ./virt-what line 119 (echo -e): > │ > if ( { echo -e "GET /latest/meta-datainstance/instance-type > HTTP/1.0\r\nHost: 100.100.100.200\r\n\r" │ > >&3; grep -sq 'ebm' <&3 ; } 3<> /dev/tcp/100.100.100.200/80 ) 2>/dev/null ; then │ > possible bashism in ./virt-what line 119 (/dev/(tcp|udp)): > │ > if ( { echo -e "GET /latest/meta-datainstance/instance-type > HTTP/1.0\r\nHost: 100.100.100.200\r\n\r" │ > >&3; grep -sq 'ebm' <&3 ; } 3<> /dev/tcp/100.100.100.200/80 ) 2>/dev/null ; then > > Can this be fixed? as that is the only bashisms in virt-what. Can you send a patch to fix it? Also I really wish there was a way to detect this while still using bash. Maybe we can use bash --posix during tests? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
