On 1/7/22 3:33 PM, Jonathon Jongsma wrote: > Add the ability to set the ioapic driver using the --features argument: > > $ virt-install --features ioapic.driver=qemu ... > > This results in the following xml: > > <features> > ... > <ioapic driver="qemu"/> > </features> > > This is required in order to install a guest with >255 cpus. Such a > configuration requires an iommu with extended interrupt mode enabled, > which in turn requires IOMMU interrupt remapping to be enabled, which in > turn requires a split I/O APIC. > Code looks fine, but this needs a test_cli.py addition: ... tests/test_checkprops.py .F [100%] ============================================= FAILURES ============================================= ______________________________________ testCheckCLISuboptions ______________________________________ Traceback (most recent call last): File "/home/crobinso/src/virt-manager/tests/test_checkprops.py", line 63, in testCheckCLISuboptions pytest.fail(msg) File "/usr/lib/python3.10/site-packages/_pytest/outcomes.py", line 153, in fail raise Failed(msg=msg, pytrace=pytrace) Failed: --features ioapic.driver Thanks, Cole