Re: [PATCH virt-manager v2 2/2] virtManager: change MDEV display names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ping!

On 11/12/21 11:51, Shalini Chellathurai Saroja wrote:
The MDEV devices listed in the "Add New Virtual Hardware" page, are a
concatenation of parent device name and MDEV device name, eg:
css_0_0_0014 mdev_b204c698_6731_4f25_b5f4_894614a05ec0_0_0_0014. The
parent name is duplicated in here, as the MDEV device name itself includes
a part of the parent name in libvirt version 7.8.0 and later. So, this patch
changes the MDEVs listed in "Add New Virtual Hardware" page to only display
the MDEV device
name(eg:mdev_b204c698_6731_4f25_b5f4_894614a05ec0_0_0_0014), when the
new naming convention is used.

Signed-off-by: Shalini Chellathurai Saroja <shalini@xxxxxxxxxxxxx>
---
  virtManager/addhardware.py | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py
index 13b899c3..132ba4e0 100644
--- a/virtManager/addhardware.py
+++ b/virtManager/addhardware.py
@@ -782,7 +782,9 @@ class vmmAddHardware(vmmGObjectUI):
                      if dev.xmlobj.name == subdev.xmlobj.parent:
                          prettyname += " (%s)" % subdev.pretty_name()
- if devtype == "mdev":
+            # parent device names are appended with mdev names in
+            # libvirt 7.8.0
+            if devtype == "mdev" and len(prettyname) <= 41:
                  for parentdev in self.conn.list_nodedevs():
                      if dev.xmlobj.parent == parentdev.xmlobj.name:
                          prettyname = "%s %s" % (

--
Kind regards
Shalini Chellathurai Saroja
Linux on Z and Virtualization Development
Vorsitzende des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294





[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux