On 6/21/21 2:43 PM, Michal Privoznik wrote: > There are two domain XML knobs specific to NVDIMMs that > virt-install doesn't allow to set: <pmem/> and <alignsize/>. > Implement them. > > Closes: https://github.com/virt-manager/virt-manager/issues/267 > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > tests/data/cli/compare/virt-install-singleton-config-3.xml | 2 ++ > tests/test_cli.py | 2 +- > virtinst/cli.py | 4 ++++ > virtinst/devices/memory.py | 2 ++ > 4 files changed, 9 insertions(+), 1 deletion(-) Actually, there's a third option that's missing: <target> <readonly/> </target>. Will post v2 shortly. Michal
