Re: [PATCH virt-install v1 1/3] virt-install: add mediated device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/14/21 11:18 AM, Shalini Chellathurai Saroja wrote:
> Add support to install a virtual server with passed-through mediated
> device. Mediated device can be created using vGPU attached to
> vfio_pci driver or DASD attached to vfio_ccw driver or APQNs attached
> to vfio_ap driver.
> 
> Signed-off-by: Shalini Chellathurai Saroja <shalini@xxxxxxxxxxxxx>
> ---
>  .../cli/compare/virt-install-many-devices.xml | 19 +++++++++
>  tests/data/testdriver/testdriver.xml          | 40 +++++++++++++++++++
>  tests/test_cli.py                             |  3 ++
>  tests/test_nodedev.py                         | 30 ++++++++++++++
>  virtinst/devices/hostdev.py                   | 34 +++++++++++++++-
>  virtinst/nodedev.py                           |  4 ++
>  6 files changed, 129 insertions(+), 1 deletion(-)

Sorry for the massively delayed review.

This patch looks good. I pushed this patch with a tweak to the
hostdev.py error message.

I'll follow up to the other patches individually

Thanks,
Cole




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux