Re: [virt-manager PATCH] virtinst: fix error message format string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/10/21 8:54 AM, Roman Bogorodskiy wrote:
> Fix a regression introduced by commit 71f034d6b where
> format string expects kwarg "domain", but "vm" is passed instead.
> 
> Signed-off-by: Roman Bogorodskiy <bogorodskiy@xxxxxxxxx>
> ---
>  virtinst/virtxml.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virtinst/virtxml.py b/virtinst/virtxml.py
> index bd2b4282..0c8da37e 100644
> --- a/virtinst/virtxml.py
> +++ b/virtinst/virtxml.py
> @@ -251,7 +251,7 @@ def start_domain_transient(conn, xmlobj, devs, action, confirm):
>          dom = conn.createXML(xmlobj.get_xml())
>      except libvirt.libvirtError as e:
>          fail(_("Failed starting domain '%(domain)s': %(error)s") % {
> -                 "vm": xmlobj.name,
> +                 "domain": xmlobj.name,
>                   "error": e,
>               })
>      else:
> 

Pushed, thanks. Also I pushed a follow up patch to fix the test case
that should have caught this

- Cole




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux