On 2/6/21 8:18 AM, Roman Bogorodskiy wrote:
> Roman Bogorodskiy (2):
> virtinst: prefer SATA bus for bhyve
> virtinst: bhyve: properly configure loader
>
> virtinst/connection.py | 2 ++
> virtinst/devices/disk.py | 3 +++
> virtinst/domain/os.py | 16 ++++++++++++++++
> 3 files changed, 21 insertions(+)
>
Thanks for the patches. We need to add test coverage though, which since
these will be the first bhyve tests will take some plumbing.
* Drop bhyve `virsh capabilities` in tests/data/capabilities/bhyve.xml
* Drop bhyve `virsh domcapabilities` in
tests/data/capabilities/bhyve-domcaps.xml
* In tests/utils.py:_URIs, add self.bhyve = _m("bhyve:///") +
_caps("bhyve.xml") + _domcaps("bhyve-domcaps.xml")
* in tests/test_cli.py add something like this:
```
########################
# bhyve specific tests #
########################
c = vinst.add_category("bhyve", "--name foobhyve --noautoconsole
--connect " + utils.URIs.bhyve)
c.add_compare("--os-variant fedora27", "bhyve-default-f27")
```
* Run the test suite, verify the generated
./tests/data/cli/compare/virt-install-bhyve-default-f27.xml looks sane.
That will all be the first commit. The next patches should cause test
output changes, use `pytest --regenerate-output` to refresh the test XML
and commit the difference.
Also check `pytest --cov` doesn't regress
Thanks,
Cole
- Cole
