On Fri, Aug 28, 2020 at 10:40:07AM -0400, Frediano Ziglio wrote: > > > > On Fri, Aug 28, 2020 at 10:22:49AM -0400, Frediano Ziglio wrote: > > > > > > > > On Thu, Aug 27, 2020 at 09:39:37PM +0300, Uri Lublin wrote: > > > > > rhbz#1848267 > > > > > > > > > > Signed-off-by: Uri Lublin <uril@xxxxxxxxxx> > > > > > > > > Patches need to be subitted as pull requests to the gitlab repo > > > > please. > > > > > > > > > --- > > > > > > > > > > Should po/* files be modified too ? > > > > > > > > Not really. There's no need to keep changing copyright dates in source > > > > files in general. > > > > > > > > > > Yes, but the string this patch refers is marked as translatable and it's > > > translated in some *.po files. It's not about source file dates. > > > > We should make it non-translatable, as it doesn't make sense to change > > copyright statements in translations. > > > > I remember some cases where some people complained that in some countries > the "(C)" was not correct from the legal point of view and needed the usage > of ©. I can't see that as a real issue since every single source file uses "(C)" in license boilerplate and never gets translated. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|