On Wed, Jul 08, 2020 at 08:54:46AM +0200, Pino Toscano wrote:
> This patch series improve the handling of translations.
>
> Split the current virt-manager catalog in two:
> - a virt-manager one, containing only the messages for the GUI; its
> translations are still build and installed as usual
> - a virt-manager-meta one, containing only the messages in .in files
> (e.g. the appdata and the desktop files); its translations are used to
> create the translated versions of the files, and not installed
>
> To make sure the translations are updated in Weblate, commit the two
> catalogs in the repository.
If I understand this correctly by creating the meta translations we can
reduce the size of installed translations.
In general it's not a bad idea especially if a project has a lot of
these translations where it can make a significant difference, but
I don't see any benefit of using this approach in virt-manager.
Based on these patches we have only 7 strings that would be moved to
the meta translations which doesn't look like it will make any
difference.
I'm not convinced that we want to make this change.
The remaining part of the series is a nice improvement to use gettext,
but I would definitely reorganize the patches:
- cleanup the current code
- switch to using gettext including changes to RPM spec files and
documentation
- introduce new functionality or changes (in this chase the split
to meta translations which I don't thing we should do in
virt-manager)
Pavel
Attachment:
signature.asc
Description: PGP signature
