On 1/9/20 11:14 PM, Lin Ma wrote: > For a shutoff VM, If user select uefi firmware auto selection, e.g. > <os firmware='efi'> > ... > </os> > > Its firmware information is set to 'BIOS' in details, This is incorrect. > This fixes it. > > Signed-off-by: Lin Ma <lma@xxxxxxxx> > --- > virtManager/details/details.py | 7 +++++-- > virtinst/domain/os.py | 3 +++ > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/virtManager/details/details.py b/virtManager/details/details.py > index dc42e35f..8cdb4804 100644 > --- a/virtManager/details/details.py > +++ b/virtManager/details/details.py > @@ -2027,8 +2027,11 @@ class vmmDetails(vmmGObjectUI): > > # Firmware > domcaps = self.vm.get_domain_capabilities() > - firmware = domcaps.label_for_firmware_path( > - self.vm.get_xmlobj().os.loader) > + if self.vm.get_xmlobj().os.is_uefi_auto_selection(): > + firmware = 'UEFI firmware auto selection' I think the label should just be 'UEFI'. Maybe this will change if/when we expose firmware='efi' in the UI Also you can call self.vm.get_xmlobj().is_uefi() which provides a similar check already, the virtinst/ change isn't necessary Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
