From: d032747 <michael.trapp@xxxxxxx>
>From a security perspective virtio should be the preferred transport
and therefore the default transport order is virtio, disk[, xenstore]
A more problematic situation is an active vhostmd disk in the qemu config
combined with a deactivated disk in the vhostmd config.
This configuration error would result in missing updates for vm-dump-metrics
and a changed default transport order helps to prevent this situation.
---
vm-dump-metrics/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/vm-dump-metrics/main.c b/vm-dump-metrics/main.c
index aff92ad..d902ac3 100644
--- a/vm-dump-metrics/main.c
+++ b/vm-dump-metrics/main.c
@@ -127,10 +127,10 @@ int main(int argc, char *argv[])
/*
* If no metrics source is specfied, try default order
- * disk, virtio, xenstore
+ * virtio, disk, xenstore
*/
- if (dump_metrics(dfile) == -1) {
- if (dump_virtio_metrics(dfile) == -1) {
+ if (dump_virtio_metrics(dfile) == -1) {
+ if (dump_metrics(dfile) == -1) {
#ifdef WITH_XENSTORE
if (dump_xenstore_metrics(dfile) == -1)
exit(1);
--
2.24.0
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
