On 8/13/19 2:57 AM, Menno Lageman wrote:
> QEMU version 2.12.1 introduced a performance feature under commit
> be7773268d98 ("target-i386: add KVM_HINTS_DEDICATED performance hint").
> Support for this performance hint was added in libvirt 5.7.0 by commit
> cb12c59dac04 ("qemu: support for kvm-hint-dedicated performance hint").
>
> This patch extends virt-install's existing --features option to insert the
> appropriate XML into the guest definition if this feature is specified
> on the command line.
>
> E.g. --features='kvm_hint_dedicated=on' would result
> in the following XML:
>
> <features>
> ...
> <kvm>
> <hint-dedicated state='on'/>
> </kvm>
> ...
> </features>
>
I've pushed this now with some changes. The main thing is that the cli
is now only
--features kvm.hint-dedicated.state=on|off
As this matches the actual XML names. That is the pattern we are
following with all new XML command line pieces so it's easier for users
to reason about the virt-install/virt-xml naming given any XML name. I
tweaked the commit message to match this new naming
And I made small changes to the tests to ensure the test suite doesn't
fail on non-latest libvirt
Thanks,
Cole
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
