Re: [virt-manager PATCH] cli: Add --clock timer[0-9]*.track, timer[0-9]*.mode, timer[0-9]*.frequency options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 14, 2019 at 02:49:16PM +0300, Athina Plaskasoviti wrote:
XML Mapping:

<clock>
...
 <timer track="X" mode="X" frequency="X"/>
...
</clock>

Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@xxxxxxxxx>
---
.../compare/virt-install-singleton-config-2.xml             | 6 ++++++
tests/clitest.py                                            | 2 +-
virtinst/cli.py                                             | 6 ++++++
virtinst/domain/clock.py                                    | 3 +++
4 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/tests/cli-test-xml/compare/virt-install-singleton-config-2.xml b/tests/cli-test-xml/compare/virt-install-singleton-config-2.xml
index 9d5907c5..cf03abec 100644
--- a/tests/cli-test-xml/compare/virt-install-singleton-config-2.xml
+++ b/tests/cli-test-xml/compare/virt-install-singleton-config-2.xml
@@ -150,6 +150,9 @@
    <timer name="hpet" present="yes"/>
    <timer name="hypervclock" present="no"/>
    <timer name="pit" tickpolicy="delay"/>
+    <timer name="rtc" track="wall"/>
+    <timer name="tsc" frequency="10"/>
+    <timer name="tsc" mode="emulate"/>
  </clock>
  <on_poweroff>destroy</on_poweroff>
  <on_reboot>destroy</on_reboot>
@@ -368,6 +371,9 @@
    <timer name="hpet" present="yes"/>
    <timer name="hypervclock" present="no"/>
    <timer name="pit" tickpolicy="delay"/>
+    <timer name="rtc" track="wall"/>
+    <timer name="tsc" frequency="10"/>
+    <timer name="tsc" mode="emulate"/>

The 'mode' attribute is not used by libvirt's QEMU driver, it's only
relevant for libxl.

(And I found that out because I was curious how libvirt reacts to
multiple timer elements with the same name)

Jano

  </clock>
  <on_poweroff>destroy</on_poweroff>
  <on_reboot>restart</on_reboot>

Attachment: signature.asc
Description: PGP signature

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux