Hey,
I'm not really comfortable with that patch, which ignores some errors,
and adds some code not to crash when we do that, in the hope that the
end result will make sense. I'm under the impression that if the oVirt
instance does not have the permissions issues that you mention, but if
instead we get a temporary networking issue at the wrong time (for
example), then rather than doing the proper checks, we'll just ignore
the error, and assume the image we got is accessible to our VM?
Isn't this a problem in the oVirt REST API if you can access a
datacenter, a VM, but have no way to know if they are related?
A few small comments below,
On Tue, May 28, 2019 at 11:11:41AM -0300, Eduardo Lima (Etrunko) wrote:
> ping
>
> On 4/10/19 5:20 PM, Eduardo Lima (Etrunko) wrote:
> > When accessing ovirt as a regular user, it may happen that queries to
> > Hosts, Clusters and Data Centers return errors due to insufficient
> > permissions, while they will work fine if access is done by admin user.
> > In this case, we skip the errors and fallback to the old method.
> >
> > Signed-off-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx>
> > ---
> > src/ovirt-foreign-menu.c | 51 ++++++++++++++++++++++++++++++----------
> > 1 file changed, 39 insertions(+), 12 deletions(-)
> >
> > diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
> > index 59c3d48..83bdf5b 100644
> > --- a/src/ovirt-foreign-menu.c
> > +++ b/src/ovirt-foreign-menu.c
> > @@ -627,12 +627,21 @@ G_GNUC_END_IGNORE_DEPRECATIONS
> > }
> >
> > static gboolean storage_domain_attached_to_data_center(OvirtStorageDomain *domain,
> > - OvirtDataCenter *data_center)
> > + OvirtDataCenter *data_center)
> > {
> > GStrv data_center_ids;
> > char *data_center_guid;
> > gboolean match;
> >
> > + /* For some reason we did not get data center information, so just return
> > + * TRUE as it will work like a fallback to old method, where we did not
> > + * check relationship between data center and storage domain.
> > + */
> > + if (data_center == NULL) {
> > + g_debug("Could not get data center info, considering storage domain is attached to it");
> > + return TRUE;
> > + }
> > +
> > g_object_get(domain, "data-center-ids", &data_center_ids, NULL);
> > g_object_get(data_center, "guid", &data_center_guid, NULL);
> > match = strv_contains((const gchar * const *) data_center_ids, data_center_guid);
> > @@ -746,9 +755,6 @@ static void data_center_fetched_cb(GObject *source_object,
> > ovirt_resource_refresh_finish(resource, result, &error);
> > if (error != NULL) {
> > g_debug("failed to fetch Data Center: %s", error->message);
> > - g_task_return_error(task, error);
> > - g_object_unref(task);
> > - return;
This leaks 'error'
> > }
> >
> > ovirt_foreign_menu_next_async_step(menu, task, STATE_DATA_CENTER);
> > @@ -763,6 +769,12 @@ static void ovirt_foreign_menu_fetch_data_center_async(OvirtForeignMenu *menu,
> > g_return_if_fail(OVIRT_IS_CLUSTER(menu->priv->cluster));
> >
> > menu->priv->data_center = ovirt_cluster_get_data_center(menu->priv->cluster);
> > +
> > + if (menu->priv->data_center == NULL) {
> > + ovirt_foreign_menu_next_async_step(menu, task, STATE_DATA_CENTER);
> > + return;
> > + }
> > +
> > ovirt_resource_refresh_async(OVIRT_RESOURCE(menu->priv->data_center),
> > menu->priv->proxy,
> > g_task_get_cancellable(task),
> > @@ -783,9 +795,6 @@ static void cluster_fetched_cb(GObject *source_object,
> > ovirt_resource_refresh_finish(resource, result, &error);
> > if (error != NULL) {
> > g_debug("failed to fetch Cluster: %s", error->message);
> > - g_task_return_error(task, error);
> > - g_object_unref(task);
> > - return;
This leaks 'error'
> > }
> >
> > ovirt_foreign_menu_next_async_step(menu, task, STATE_CLUSTER);
> > @@ -797,9 +806,21 @@ static void ovirt_foreign_menu_fetch_cluster_async(OvirtForeignMenu *menu,
> > {
> > g_return_if_fail(OVIRT_IS_FOREIGN_MENU(menu));
> > g_return_if_fail(OVIRT_IS_PROXY(menu->priv->proxy));
> > - g_return_if_fail(OVIRT_IS_HOST(menu->priv->host));
> >
> > - menu->priv->cluster = ovirt_host_get_cluster(menu->priv->host);
> > + /* If there is no host information, we get cluster from the VM */
> > + if (menu->priv->host == NULL) {
> > + g_return_if_fail(OVIRT_IS_VM(menu->priv->vm));
> > + menu->priv->cluster = ovirt_vm_get_cluster(menu->priv->vm);
> > + } else {
> > + g_return_if_fail(OVIRT_IS_HOST(menu->priv->host));
> > + menu->priv->cluster = ovirt_host_get_cluster(menu->priv->host);
> > + }
> > +
> > + if (menu->priv->cluster == NULL) {
> > + ovirt_foreign_menu_next_async_step(menu, task, STATE_CLUSTER);
> > + return;
> > + }
> > +
> > ovirt_resource_refresh_async(OVIRT_RESOURCE(menu->priv->cluster),
> > menu->priv->proxy,
> > g_task_get_cancellable(task),
> > @@ -820,9 +841,6 @@ static void host_fetched_cb(GObject *source_object,
> > ovirt_resource_refresh_finish(resource, result, &error);
> > if (error != NULL) {
> > g_debug("failed to fetch Host: %s", error->message);
> > - g_task_return_error(task, error);
> > - g_object_unref(task);
> > - return;
This leaks 'error'
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
