Re: [virt-bootstrap PATCH 1/3] safe-untar: Inherit SElinux context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/4/19 6:26 AM, Radostin Stoyanov wrote:
> Lets virt-sandbox inherit the SElinux context of virt-bootstrap.
> 
> Signed-off-by: Radostin Stoyanov <rstoyanov1@xxxxxxxxx>
> ---
>  src/virtBootstrap/utils.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/virtBootstrap/utils.py b/src/virtBootstrap/utils.py
> index cd03a93..b0f695d 100644
> --- a/src/virtBootstrap/utils.py
> +++ b/src/virtBootstrap/utils.py
> @@ -269,6 +269,7 @@ def safe_untar(src, dest):
>      Extract tarball within LXC container for safety.
>      """
>      virt_sandbox = ['virt-sandbox',
> +                    '-s', 'inherit',
>                      '-c', LIBVIRT_CONN,
>                      '--name=bootstrap_%s' % os.getpid(),
>                      '-m', 'host-bind:/mnt=' + dest]  # Bind destination folder
> 

Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx>

Side note: I prefer long option variants in cases like this, makes the
command invocation more self documenting for those who don't know what
the short options are.

Thanks,
Cole

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list



[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux